Skip to content

[DNM][CI bisect] Revert #58197 to identify FT E2E detection hang #58318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vllm-agent wants to merge 2 commits into from
Closed

[DNM][CI bisect] Revert #58197 to identify FT E2E detection hang #58318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88bd9aa
Revert "[Core] Disable JIT warmup in eager mode (#58197)"
khluu Sep 23, 2026
c7b1e3a
[DNM] Touch FT test file to force lane selection on this bisect probe
vllm-agent Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/v1/fault_tolerance/test_fault_tolerance_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
# - CPU: Gloo DP allreduce timeout (30s) detects the dead peer.
# - nixl_ep: kernel masks the dead rank after Buffer's default timeout_ms=30000 (30s).
# - Deadline (45s): slowest fallback (30s) + margin.
# NOTE: comment-only change to keep this lane selected by CI test
# selection on the #58318 bisect probe; remove before any real merge.
CPU_DISTRIBUTED_TIMEOUT_S = 30
FAULT_DETECTION_DEADLINE_S = 45

Expand Down
7 changes: 2 additions & 5 deletions vllm/config/vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,14 +1667,11 @@ def __post_init__(self):

if self.model_config is not None and self.model_config.enforce_eager:
logger.warning_once(
"Enforce eager set, disabling torch.compile, CUDAGraphs, and JIT "
"kernel warmup. This is equivalent to setting -cc.mode=none "
"-cc.cudagraph_mode=none and "
"--kernel_config.enable_jit_warmup=False"
"Enforce eager set, disabling torch.compile and CUDAGraphs. "
"This is equivalent to setting -cc.mode=none -cc.cudagraph_mode=none"
)
self.compilation_config.mode = CompilationMode.NONE
self.compilation_config.cudagraph_mode = CUDAGraphMode.NONE
self.kernel_config.enable_jit_warmup = False

if os.environ.get("TORCH_COMPILE_DISABLE") == "1":
logger.warning_once(
Expand Down
Loading