Repository navigation
[DNM][CI bisect] Revert #58197 to identify FT E2E detection hang - #58318
vllm-agent wants to merge 2 commits into
Conversation
|
/ci run |
|
✅ Triggered Buildkite CI #90636 for commit |
d543e06 to
9debc2f
Compare
|
/ci run |
|
✅ Triggered Buildkite CI #90788 for commit |
|
/ci run |
|
❌ This PR is 2 commits behind upstream |
|
/ci run |
063327d to
c7b1e3a
Compare
|
✅ Triggered Buildkite CI #90793 for commit |
|
Context for a forward fix (per @khluu's preference over this revert): Empirically proven: reverting #58197 makes the FT lane pass (build #90793, 2/2 green); main fails deterministically since #58197 merged. So the trigger is specifically What Observed failure shape: in Not yet pinned: which specific warmed kernel the survivor's fault-time path depends on (the failing log shows router-GEMM/FlashInfer warmups still ran — so it's specifically the gated batch that matters). A forward fix could be as narrow as: don't disable JIT warmup when |
|
I think we can just drop |
|
I opened #58593 which should hopefully forward-fix the test, implementing the bot's suggestion.
|
Bisecting the main-branch Fault Tolerance E2E hang (rank 0 never reports UNHEALTHY after injected fault; broke between daily #90513 and #90560).
This PR reverts #58197 (disable JIT warmup in eager mode — the FT lane runs --enforce-eager). Do not merge — bisect probe only; will be closed once the culprit is identified. Sibling probe: #58317 (revert #55891).