Repository navigation
[Bugfix] DiffusionGemma: fix multimodal support - #57589
Merged
Merged
Conversation
Gemma4ForConditionalGeneration._process_image_input, which this model reuses, reads self._enable_mm_lora, set in Gemma4's constructor and not in this one, so any image request raised AttributeError in the encoder runner and took the engine down. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Matt Mastracci <matthew@mastracci.com>
4 tasks done
LucasWilkinson
approved these changes
Sep 18, 2026
LucasWilkinson
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks for splitting this out!
Contributor
|
/ci run |
Contributor
|
/ci run |
|
✅ Triggered Buildkite CI #89902 for commit |
|
✅ @mmastrac, CI is now available for this PR.
|
|
✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/89902 |
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #90083 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DiffusionGemma reuses
Gemma4ForConditionalGeneration._process_image_inputfor its image path. That method readsself._enable_mm_lora, which Gemma4's constructor sets. DiffusionGemma's doesn't, so any request with an image raisesAttributeErrorin the encoder runner and takes the engine down.Set the flag in DiffusionGemma's constructor the same way Gemma4 does.
Required for #57250 to support multimodal inputs.
Test plan
Hardware: 1 DGX Spark.
Send an image.
Test results
Without patch: 500 error (AttributeError)
With patch: a successful response
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.