Repository navigation
Conversation
…ement vllm-project#55557 and vllm-project#54222 merged shortly before vllm-project#52136 enabled the ruff `D` rules, so the three multi-line docstrings they added were never checked against D209. `pre-commit run ruff-check --all-files` now fails on main by rewriting these files. This commit applies that auto-fix. Signed-off-by: Flora Feng <4florafeng@gmail.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: sfeng33 <4florafeng@gmail.com>
Member
Author
|
/ci run |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
✅ Triggered Buildkite CI #89387 for commit |
AndreasKaratzas
approved these changes
Sep 16, 2026
AndreasKaratzas
enabled auto-merge (squash)
September 16, 2026 17:41
github-actions
Bot
added
the
ready
hmellor
disabled auto-merge
September 16, 2026 17:59
Member
|
Superseded by #57212 We opted to revert D209 and all the newlines it added, they were not worth it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
pre-commit run ruff-check --all-filesfails on currentmain(1085b64): ruff's D209 (multi-line docstring closing quotes on their own line) flags three docstrings and the hook rewrites the files.Merge race: #55557 (15:07 UTC) and #54222 (15:23 UTC) added these docstrings, and #52136 (16:44 UTC) enabled the
Dpydocstyle rules. Neither side ever checked these three docstrings against D209.This PR applies the ruff auto-fix. No behavior change.
Test Plan