[Bugfix][ROCm] Create linear layer biases with requires_grad=False - #56161
Merged
Merged
Conversation
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
|
✅ @micah-wil, CI is now available for this PR.
|
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #88000 for commit |
Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #88140 for commit |
AndreasKaratzas
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
After upgrading to AITER v0.1.21.post2 on ROCm in #55968, we are seeing the following test failure:
e.g. https://buildkite.com/vllm/amd-ci/builds/12759/list?jid=01a08458-ac70-43e6-89e7-7c9668624b86&tab=output
This happened after ROCm/aiter#5145, which replaced
splitk_hgemm/small_m_hgemmFlyDSL kernels withgemm_a16w16_gfx950. This kernel uses DLPack, so the biases are rejected because they use the defaultrequires_grad=True(pytorch prohibits sending tensors to dlpack w/requires_grad=True):Weights explicitly set
requires_grad=Falseso they export fine, but linear biases do not (ReplicatedLinear,ColumnParallelLinear,RowParallelLinear). Here, I explicitly setrequires_grad=Falseon the bias tensors to make them compatible with DLPack. This should have no unintended side effects as nothing in vLLM reads a bias's requires_grad.Test Plan
pytest -s -v evals/gpt_oss/test_gpqa_correctness.py::test_gpqa_correctness[gpt-oss-20b-rocm-quark-mxfp4-fp8-triton] --config-list-file=configs/models-gfx950.txtTest Result