[CI][Test][Spec Decode] Fix CI failure of Qwen3 Omni DSpark loader mock - #56011
Merged
Merged
Conversation
Signed-off-by: Jing Wang <jingwang96@qq.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correct test-fixture update that matches the accessed configuration fields and has no apparent behavioral risk beyond fixing the failing unit test.
Pull request overview
Fixes a unit-test fixture for the Qwen3 Omni DSpark loader by extending the SimpleNamespace-based vllm_config mock so it matches the fields now accessed by load_dspark_model.
Changes:
- Add
parallel_configto the test’svllm_configmock to satisfyload_dspark_model’svllm_config.parallel_configaccess. - Populate
draft_parallel_config.tensor_parallel_sizein the mock to satisfyspeculative_config.draft_parallel_config.tensor_parallel_sizeaccess.
File summaries
| File | Description |
|---|---|
| tests/model_executor/test_qwen3_omni.py | Updates the DSpark unit-test config mock to include required parallel_config and tensor_parallel_size fields. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gau-nernst
approved these changes
Sep 9, 2026
Contributor
|
/ci run |
|
✅ Triggered Buildkite CI #87837 for commit |
Isotr0py
approved these changes
Sep 9, 2026
Isotr0py
enabled auto-merge (squash)
September 9, 2026 06:04
github-actions
Bot
added
the
ready
ywang96
approved these changes
Sep 9, 2026
ywang96
disabled auto-merge
September 9, 2026 06:06
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 10, 2026
…ck (vllm-project#56011) Signed-off-by: Jing Wang <jingwang96@qq.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
PR #55472 changed
load_dspark_modelto derive the draft parallel configuration from the targetvllm_config.parallel_config, but missed updating text fixture in unit testtest_qwen3_omni.py.The test uses an incomplete
SimpleNamespacemock and fails with:This PR add the missing
parallel_config.Thanks @gau-nernst for the catch!
Test Plan
The main unit test:
and some related:
Test Result
All (8 + 32) passed.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.