Skip to content

[CI] fix pre-commit - #55630

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
ZJY0516:ci/fix-pre-commit
Sep 7, 2026
Merged

[CI] fix pre-commit#55630
vllm-bot merged 1 commit into
vllm-project:mainfrom
ZJY0516:ci/fix-pre-commit

Conversation

@ZJY0516

@ZJY0516 ZJY0516 commented Sep 7, 2026

Copy link
Copy Markdown
Member

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T02:32:39.351209Z 5379fe7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: b9a94bb4-5ba4-4432-9d65-a2f883e4336f

📥 Commits

Reviewing files that changed from the base of the PR and between 294fbb4 and 5379fe7.

📒 Files selected for processing (1)
  • csrc/libtorch_stable/quantization/w8a8/cutlass/c3x/scaled_mm_blockwise_sm120_fp8.cu

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Reformatted an internal comment for improved readability.
    • No user-visible functionality or behavior changed.

Walkthrough

The change re-wraps a comment about max_swizzle_size = 8 in the CUTLASS FP8 implementation. No functional code changes were made.

Changes

Comment Formatting

Layer / File(s) Summary
Re-wrap tile scheduler comment
csrc/libtorch_stable/quantization/w8a8/cutlass/c3x/scaled_mm_blockwise_sm120_fp8.cu
The comment describing max_swizzle_size = 8 is split across two lines.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5379f

This updates comment formatting only and does not change product behavior. No merge-readiness risk remains.

Suggested reviewers: jschmied

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title states that the pull request fixes pre-commit, but the changeset only reformats a comment in scaled_mm_blockwise_sm120_fp8.cu. Update the title to describe the comment reformat, or include the pre-commit-related changes that the current title implies.
Description check ❓ Inconclusive The description contains only empty Purpose, Test Plan, and Test Result sections. It does not provide meaningful information about the comment-only change. Add a concise purpose, the validation or formatting command used, and the test result. State that no functional code changed if no tests were required.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5379fe7a38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +14 to +15
// 8192x8192 is at 54 from M=6144. With the tile scheduler's max_swizzle_size =
// 8 the same launches run at 150-174 TFLOPS at every M, bit-identical to the

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Drop the standalone formatting-only change

This commit only reflows an existing comment and makes no behavioral change, so as a standalone contribution it is exactly the one-off mechanical cleanup that the repository requires contributors not to submit; bundle it with substantive work instead of proceeding with this change alone.

AGENTS.md reference: AGENTS.md:L21-L23

Useful? React with 👍 / 👎.

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Sep 7, 2026
@ZJY0516

ZJY0516 commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #87468 for commit 5379fe7a3828.

@gau-nernst

Copy link
Copy Markdown
Contributor

Sorry, caused by #55180 force merge 🤡

@Isotr0py
Isotr0py enabled auto-merge (squash) September 7, 2026 02:59
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 7, 2026
@vllm-bot
vllm-bot merged commit f43ef15 into vllm-project:main Sep 7, 2026
304 of 312 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Sep 7, 2026
ItsRoy69 pushed a commit to ItsRoy69/vllm that referenced this pull request Sep 10, 2026
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants