Repository navigation
[Feat][MM Cache] Skip media loading & decoding if UUID based cache lookup succeeds #55583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jankwi
wants to merge
14
commits into
vllm-project:main
Choose a base branch
from
Jankwi:feat/early-cache-lookup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
9b8363f
Test that video loading is not skipped in the current implementation
1a6a430
Make it possible to skip media loadingfor video and images
5853f06
Add skip_early_mm_lookup param to opt-out of early mm lookups per req…
0bade85
Add docs for change
46cd0e0
Merge branch 'vllm-project:main' into feat/early-cache-lookup
Jankwi 166ffdb
Disable early lookups for vision chunks
5a234b2
Merge branch 'vllm-project:main' into feat/early-cache-lookup
Jankwi 3d28775
Remove env var and retry race condition failures
623e1d2
Merge branch 'main' into feat/early-cache-lookup
Jankwi 5deff0a
[DRAFT]: Simplify lookups
Jankwi d442a08
Merge branch 'main' into feat/early-cache-lookup
Jankwi 1348d4e
Complete redesign
Jankwi b8b67c7
Minor changes (renames, tests, reorganization)
Jankwi a0fd123
Merge branch 'main' into feat/early-cache-lookup
Jankwi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 50374
🤖 get_repo_knowledge executed:
get_repo_knowledge vllm-project/vllm /tmp/coderabbit-repo-knowledge/vllm-project-vllm-8d5490deLength of output: 621
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 41781
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 40008
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 1761
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 1246
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 22136
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 50373
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 6425
IDOR (CWE-639): Authorization Bypass Through User-Controlled Key (IDOR)
Reachability: External · Exploitability: Difficult
Do not treat UUID-authoritative hits as an authorization boundary.
The cache intentionally uses
uuidas the media identity and ignores the URL on a hit. In a shared server, a caller who obtains another tenant’s UUID can receive model output derived from that tenant’s media. Bind cache keys to the tenant or authorize UUID access. Otherwise, require cryptographically random tenant-unique UUIDs and protect them as bearer secrets.cache_saltalone does not isolate the processor cache.🤖 Prompt for AI Agents