Skip to content

[ROCm][CI] Bump ROCk release image build timeout to 3h - #55354

Merged
dllehr-amd merged 1 commit into
vllm-project:mainfrom
Rohan138:rock-release-timeout
Sep 4, 2026
Merged

dllehr-amd merged 1 commit into
vllm-project:mainfrom
Rohan138:rock-release-timeout

Conversation

@Rohan138

@Rohan138 Rohan138 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Raise build-rock-release-image's timeout_in_minutes from 60 to 180.

In nightly release-v2 #6097 (first run after the ROCm 10.0 base landed, #55246), :docker: Build release image - x86_64 - ROCk timed out at 60.8 min mid-compile, which blocked the nightly-rocm100 publish. The ROCk release image builds vLLM (csrc + NIXL/mori/lmcache/deepep) against a freshly built base with a cold sccache for the TheRock toolchain, so it compiles from scratch — the apt Build release image - ROCm step passes at 60 min only because it builds against a warm cache. 180 min gives the cold seed room to finish and warm the cache; warm runs finish well under it.

Not a duplicate; AI assistance (Claude Code) was used, reviewed and owned by me.

Test Plan

python3 -c "import yaml; yaml.safe_load(open('.buildkite/release-pipeline.yaml'))"

Test Result

YAML parses. Effect verified by the next nightly release-v2 run.

The ROCk release image builds vLLM (csrc + NIXL/mori/lmcache/deepep) against a
freshly built ROCm 10.0 base with a cold sccache for the TheRock toolchain. In
nightly release-v2 vllm-project#6097 it was still compiling at the 60-min limit and timed
out, blocking the nightly-rocm100 publish. Raise it to 180 min so the cold seed
can finish and warm the cache; warm runs finish well under that.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Sep 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 94d61fe0-a479-4888-85bd-1fa954c1e2b6

📥 Commits

Reviewing files that changed from the base of the PR and between a85d073 and b4ff56e.

📒 Files selected for processing (1)
  • .buildkite/release-pipeline.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Increased the allowed build time for the ROCk x86_64 release image to support longer-running release builds.

Walkthrough

The ROCK release pipeline increases the build-rock-release-image step timeout from 60 to 180 minutes.

Changes

ROCK release pipeline

Layer / File(s) Summary
Increase release image build timeout
.buildkite/release-pipeline.yaml
The build-rock-release-image step now has a 180-minute timeout instead of 60 minutes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b4ff5

The ROCk release-image build can run up to three hours, avoiding cold-cache timeout failures while leaving other pipeline behavior unchanged. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the timeout increase, the failure context, and the validation plan. It directly matches the changeset.
Title check ✅ Passed The title clearly and concisely identifies the ROCm CI change and the increase of the ROCk release image build timeout to three hours.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dllehr-amd dllehr-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@dllehr-amd
dllehr-amd enabled auto-merge (squash) September 4, 2026 15:49
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 4, 2026
@dllehr-amd

Copy link
Copy Markdown
Collaborator

/ci run

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #87280 for commit b4ff56e303e1.

@dllehr-amd
dllehr-amd merged commit 99a1ab8 into vllm-project:main Sep 4, 2026
32 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Sep 4, 2026
@Rohan138
Rohan138 deleted the rock-release-timeout branch September 4, 2026 18:40
ItsRoy69 pushed a commit to ItsRoy69/vllm that referenced this pull request Sep 10, 2026
…55354)

Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants