[ROCm][CI] Bump ROCk release image build timeout to 3h - #55354
Conversation
The ROCk release image builds vLLM (csrc + NIXL/mori/lmcache/deepep) against a freshly built ROCm 10.0 base with a cold sccache for the TheRock toolchain. In nightly release-v2 vllm-project#6097 it was still compiling at the 60-min limit and timed out, blocking the nightly-rocm100 publish. Raise it to 180 min so the cold seed can finish and warm the cache; warm runs finish well under that. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe ROCK release pipeline increases the ChangesROCK release pipeline
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The ROCk release-image build can run up to three hours, avoiding cold-cache timeout failures while leaving other pipeline behavior unchanged. The change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ci run |
|
✅ Triggered Buildkite CI #87280 for commit |
…55354) Signed-off-by: Rohan Potdar <rohan.potdar@amd.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
Purpose
Raise
build-rock-release-image'stimeout_in_minutesfrom 60 to 180.In nightly
release-v2#6097 (first run after the ROCm 10.0 base landed, #55246),:docker: Build release image - x86_64 - ROCktimed out at 60.8 min mid-compile, which blocked thenightly-rocm100publish. The ROCk release image builds vLLM (csrc + NIXL/mori/lmcache/deepep) against a freshly built base with a cold sccache for the TheRock toolchain, so it compiles from scratch — the aptBuild release image - ROCmstep passes at 60 min only because it builds against a warm cache. 180 min gives the cold seed room to finish and warm the cache; warm runs finish well under it.Not a duplicate; AI assistance (Claude Code) was used, reviewed and owned by me.
Test Plan
python3 -c "import yaml; yaml.safe_load(open('.buildkite/release-pipeline.yaml'))"Test Result
YAML parses. Effect verified by the next nightly
release-v2run.