[ROCm][CI] Bump ROCk base to ROCm 10.0 - #55246
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe ROCk Docker image now uses ROCm 10.0.0 packages, a pinned Triton wheel, and updated final-image settings. The nightly release pipeline passes ChangesROCm 10 ROCk image
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The ROCk image now targets ROCm 10.0.0 with pinned Triton packaging and ROCm 10 nightly tags. The configured package validation and publishing-tag contract are aligned, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rohan138
changed the title
Rohan138
commented
Sep 4, 2026
Rohan138
commented
Sep 4, 2026
Rohan138
commented
Sep 4, 2026
Rohan138
commented
Sep 4, 2026
Rohan138
commented
Sep 4, 2026
Rohan138
commented
Sep 4, 2026
…8.x) Bump the TheRock base image from ROCm 7.14.0 to 10.0.0, based on Randy Smith's rock10 dockerfile: torch/vision/audio 2.12.0/0.27.0/2.11.0+rocm10.0.0 from the whl-next channels, ROCM_SDK_VERSION=10.0.0, and triton pinned to the prebuilt 3.8.0+git4cff872c.rocm10.0.0 wheel (exactly torch's Requires-Dist). Switch the pipeline publish/cleanup tags from rocm714 to rocm100. Scoped down from Randy's commit for a first landing: - Drop the triton source-rebuild stage (release/internal/3.8.x @ 0d631838); the prebuilt 4cff wheel is used for now. A follow-up will add the rebuild back to pull in the newer 3.8.x commits. - Drop the AOTriton version/kernel-image guard; ROCm 10 ships stock AOTriton, and the accuracy guard is a later CI concern. - Keep the existing docker/Dockerfile.rock (Randy's triton_kernels PR-965 patch + commit bump land via a separate fix). Co-authored-by: Randall Smith <Randall.Smith@amd.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
Mirror vllm-project#52826 (which bumped Dockerfile.rocm_base) for the TheRock base image. The vLLM-side runtime adaptations from vllm-project#52826 (fused_flydsl_moe, mxfp4 test) are already on main and ride along when this merges. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
Drop the explanatory comments called out in review (TRITON_VERSION, whl-next URLs, final-stage triton, "displace our pins"), remove the redundant base-stage torch/triton verification RUN, and drop `RUN ldconfig` (only needed when rebuilding AOTriton). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
torch 2.12 attaches rocprofiler-sdk implicitly and its queue interposition hangs at HSA teardown. Set ROCPROFILER_QUEUE_INTERPOSITION=0 in the final image, matching the mitigation in vllm-project#55099 for Dockerfile.rocm_base. The ROCr/CLR and rocprofiler-sdk source rebuilds from rocm_base are not ported: they target ROCm 7.2.x and ROCm 10.0 already carries those fixes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Rohan Potdar <rohan.potdar@amd.com>
Rohan138
force-pushed
the
rock10-bump
branch
from
September 4, 2026 02:35
8bb6af1 to
8928918
Compare
Rohan138
marked this pull request as ready for review
September 4, 2026 02:36
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Rohan138
changed the title
|
✅ @Rohan138, CI is now available for this PR.
|
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #87183 for commit |
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 10, 2026
Signed-off-by: Rohan Potdar <rohan.potdar@amd.com> Co-authored-by: Randall Smith <Randall.Smith@amd.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bump the TheRock base (
docker/Dockerfile.rock_base) from ROCm 7.14.0 to 10.0.0 and switch the ROCk nightly tagsrocm714→rocm100. Based on @rasmith'sROCm:vllm:rock10dockerfile; follows #55014.Scoped for a first landing:
3.8.0+git4cff872c.rocm10.0.0wheel (exactly torch's Requires-Dist). Source rebuild fromrelease/internal/3.8.xdropped for now — follow-up.v0.1.19→v0.1.21.post1, mirroring merged [ROCm] Bump AITER to 0.1.21.post1 #52826 (its runtime changes are already on main).ENV ROCPROFILER_QUEUE_INTERPOSITION=0— torch 2.12 rocprofiler hangs at HSA teardown; mirrors [ROCm][Perf][Bugfix] Multi-stream perf improvements; rocprofiler fixes #55099. The ROCr/CLR + rocprofiler-sdk source rebuilds fromrocm_baseare not ported (7.2.x-targeted; 10.0 carries the fixes;/opt/rocmvs TheRock layout).docker/Dockerfile.rockunchanged.Not a duplicate: no open PR bumps
Dockerfile.rock_baseto ROCm 10. AI assistance (Claude Code) was used; reviewed and owned by me.Test Plan
Test Result
YAML parses;
docker build --checkclean apart from two pre-existingSCCACHE_S3_NO_CREDENTIALSlints in unmodified lines. Full image build validated by the release pipeline.