Skip to content

[CI] Disable CUDA graphs for GLM PCP evals - #54745

Merged
njhill merged 2 commits into
vllm-project:mainfrom
khluu:fix/pcp-eval-disable-cudagraph
Sep 1, 2026
Merged

njhill merged 2 commits into
vllm-project:mainfrom
khluu:fix/pcp-eval-disable-cudagraph

Conversation

@khluu

@khluu khluu commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

  • set cudagraph_mode to NONE for both GLM-5.2 NVFP4 PCP eval configurations
  • unblock the B200 LM Eval PCP lane, which currently fails before GSM8K starts

Why

MRV2 sparse MLA PCP does not support CUDA graphs yet. Nightly build #86511 failed both selected GLM PCP configurations during engine initialization with:

MRV2 sparse MLA PCP does not support CUDA graphs yet. Set -cc.cudagraph_mode=NONE.

This changes only those two test configurations. PR #53896 is not the source of this failure; it added the separate Qwen3.8 accuracy lane. The failing PCP configs were changed to PIECEWISE by PR #53869.

Duplicate check

Searched open PRs for Qwen3.8-Flash-Next PCP, cudagraph_mode=NONE PCP, GLM-5.2 PCP, and LM Eval PCP. No open PR addresses this configuration fix.

Validation

  • git diff --check
  • parsed both YAML files, split server_args with shlex, decoded the compilation config as JSON, and asserted cudagraph_mode == "NONE"

Model evaluation was not run locally because this lane requires four B200 GPUs and the GLM-5.2-NVFP4 model. The exact lm-eval-pcp-4xb200 Buildkite lane is the required validation.

AI assistance was used to investigate the CI failure and prepare this change. A human submitter must review every changed line and the validation evidence before marking the PR ready.

MRV2 sparse MLA PCP does not support CUDA graphs. Run both GLM-5.2 PCP accuracy configurations with cudagraph_mode NONE so the B200 LM Eval PCP lane can start and execute GSM8K.\n\nCo-authored-by: Codex <noreply@openai.com>

Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
@khluu
khluu marked this pull request as ready for review September 1, 2026 09:52

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Sep 1, 2026
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 1, 2026
@njhill
njhill enabled auto-merge (squash) September 1, 2026 19:09
@khluu

khluu commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #86694 for commit 45acd01d132f.

@GirasoleY

Copy link
Copy Markdown
Contributor

Thanks for fixing this!

@njhill
njhill merged commit 4bf06be into vllm-project:main Sep 1, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Sep 1, 2026
@khluu khluu added this to the v0.29.0 cherry picks milestone Sep 1, 2026
khluu added a commit that referenced this pull request Sep 2, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
mylibrar pushed a commit to tanyuqian/vllm that referenced this pull request Sep 3, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
sheralskumar pushed a commit to sheralskumar/vllm that referenced this pull request Sep 8, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

glm nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants