Revert "[Bugfix][Spec Decode] Capture the widest uniform decode batch by default" (#50488) - #54352
Draft
vllm-agent wants to merge 1 commit into
Draft
vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
… by default (vllm-project#50488)" This reverts commit d3d79ff.
Member
|
Narrow fix-forward is now draft PR #54418. It preserves #50488's dynamic-tier and safe off-stride coverage while keeping generated capture sizes under the platform default memory ceiling. Exact H200 validation: https://buildkite.com/vllm/ci/builds/86219 |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated draft revert of #50488 ("[Bugfix][Spec Decode] Capture the widest uniform decode batch by default"), which is the HEAD commit of nightly build #86121 and broke 2 H200 spec-decode jobs.
A narrower fix is preferable if the author has one — e.g. clamping the new default to the previous
512ceiling (or to available memory) instead of takingmax_num_seqs * (1 + num_spec_tokens)unconditionally. Please close this in favour of such a fix-forward.Root cause
The PR makes
max_cudagraph_capture_sizedefault to the widest uniform decode batch. Across every engine in the two failing jobs the value moved from a flat512to values driven bymax_num_seqs * (1 + num_spec_tokens):max_cudagraph_capture_size21fa2c5a/6d4562c5512for every engined3d79ff768,1024,2176,6400,6400:nvidia: (H200) Spec Decode N-Gram + Suffix— the twosuffixconfigs (num_spec_tokens=24,max_num_seqs=256→6400) die during CUDA graph capture; the two configs that stayed at768/1024passed::nvidia: (H200) Spec Decode AL DFlash Nightly—2176instead of512grows the CUDAGraph pool and peak activation, collapsing the KV cache budget:This is a default-behaviour change, so it is not CI-only: any spec-decode deployment on a memory-constrained GPU now either fails engine init or silently loses most of its KV cache.
Bisect
21fa2c5a) and 86108 (6d4562c5) both green, both reporting512.d3d79ff(this PR's squash commit) and is the first red.Dependents
d3d79ffis still the tip commit on bothvllm/config/vllm.pyandvllm/v1/worker/gpu/cudagraph_utils.py, so nothing is stacked on it. The revert applied cleanly with no conflicts and touches only the 6 files from the original PR.Auto-generated by CI failure analyzer.