[Model][Hardware][NV] Add support for ModelOpt static scaling checkpoints#5387
Closed
pavanimajety wants to merge 1 commit intovllm-project:mainfrom
Closed
[Model][Hardware][NV] Add support for ModelOpt static scaling checkpoints#5387pavanimajety wants to merge 1 commit intovllm-project:mainfrom
pavanimajety wants to merge 1 commit intovllm-project:mainfrom
Conversation
| """Replaces the names of *quantizer._amax to _scale.""" | ||
| replacements = { | ||
| "weight_quantizer._amax": "weight_scale", | ||
| "input_quantizer._amax": "act_scale", |
Collaborator
There was a problem hiding this comment.
We just tweaked this to input_scale FYI ahead of the v0.5.0 beta launch
Collaborator
|
Does this have to be implemented in |
mgoin
reviewed
Jun 10, 2024
| """Replaces the names of *quantizer._amax to _scale.""" | ||
| replacements = { | ||
| "weight_quantizer._amax": "weight_scale", | ||
| "input_quantizer._amax": "act_scale", |
Member
There was a problem hiding this comment.
This has been updated such that act_scale -> input_scale #5353
| weights_to_convert = [] | ||
| vllm_state_dict = {} | ||
| for key, value in input_state_dict.items(): | ||
| if key.endswith("_amax"): |
Member
There was a problem hiding this comment.
It would be best to make this as specific as possible to avoid possible conflicts -- would if key.endswith("_quantizer._amax"): work?
cjluo-nv
reviewed
Jun 10, 2024
| else: | ||
| return key, value | ||
|
|
||
| def _convert_ammo_weights(self, input_state_dict: Dict[str, torch.tensor]): |
There was a problem hiding this comment.
ammo is no the product name. Let's use modelopt instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for running ModelOpt FP8 checkpoints. The change converts the names of keys from ModelOpt to vLLM recognized key names in FP8 quantization mode.