[Misc][Breaking] Change FP8 checkpoint format from act_scale -> input_scale#5353
Merged
mgoin merged 7 commits intovllm-project:mainfrom Jun 8, 2024
Merged
[Misc][Breaking] Change FP8 checkpoint format from act_scale -> input_scale#5353mgoin merged 7 commits intovllm-project:mainfrom
mgoin merged 7 commits intovllm-project:mainfrom
Conversation
tlrmchlsmth
approved these changes
Jun 7, 2024
pcmoritz
reviewed
Jun 7, 2024
pcmoritz
reviewed
Jun 7, 2024
pcmoritz
approved these changes
Jun 7, 2024
Collaborator
|
Thanks Michael! |
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 9, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jun 10, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tandem with neuralmagic/AutoFP8#11.
BREAKING CHANGE: Because there can be input and output scales (
kv_scaleis an example of an "output" scale for k_proj+v_proj), the current usage ofact_scaleis quite vague. We would like to be explicit here to properly support future formats, so we are proposing to changeact_scale—>input_scale.Obviously this is going to be a breaking change for the checkpoints we have currently and against previous releases of vLLM. We think this is the right time to make such a change before we “finalize” the beta with v0.5.0 next week.
Here is a script for rewriting checkpoints with
act_scaleto use the newinput_scaleformat: