Skip to content

[Revert] MXFP4 + block-FP8 Humming support after H100 correctness failure - #53805

Draft
khluu wants to merge 1 commit into
vllm-project:mainfrom
khluu:revert/51332-h100-mxfp4-block-fp8
Draft

khluu wants to merge 1 commit into
vllm-project:mainfrom
khluu:revert/51332-h100-mxfp4-block-fp8

Conversation

@khluu

@khluu khluu commented Aug 25, 2026

Copy link
Copy Markdown
Member

Why this revert

Reverts #51332 / ca29cd48ba05 after the first exact post-merge H100 evaluation of the newly added MXFP4 + block-FP8 path produced invalid outputs:

This isolates an SM90/H100 correctness regression in the newly merged path. The server remained alive and evaluated all 1,319 prompts, so this is not an agent, startup, or model-download failure.

Coverage gap

The exact H100 Humming Activation job did not run before merge:

The daily #85561 run is the first exact H100 execution of this new config.

Validation

Local:

  • git diff --cached --check before commit
  • .venv/bin/python -m compileall -q vllm/model_executor/layers/fused_moe vllm/model_executor/layers/quantization/utils/humming_utils.py
  • uvx pre-commit run — all applicable hooks passed

Exact hardware validation at head d2ba916fe024774325baaab418d0af0352b53192:

The proposed revert is exact-green on both required architectures. Keep this PR draft until human review; CI-incident closure still requires merge plus an exact post-merge main H100 pass.

Duplicate-work check

No open PR references #51332 as a revert/fix, and no open PR or issue matched the exact MXFP4 + block-FP8 H100 failure. This revert is intentionally conservative until the feature can restore H100 correctness with exact pre-merge coverage.

AI assistance was used for CI triage, preparing the revert, and drafting this description. Kevin Luu reviewed the exact diff and validation evidence before submission.

…vation for MoE"

The first exact post-merge H100 eval for the new MXFP4 plus block-FP8 path scores 0.0000 on GSM8K with a 99.4% invalid-response rate. The same config passes on B200, isolating an SM90 correctness regression. Revert vllm-project#51332 until H100 correctness is restored and covered pre-merge.

Co-authored-by: Sherlock <sherlock@agents.local>
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
@khluu

khluu commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Exact hardware validation launched: Buildkite #85565, with only lm-eval-humming-act-h100 and lm-eval-humming-act-b200 selected. H100 is the decisive failing-family gate; B200 is the same-config control. Keep this draft until both exact jobs pass.

@mergify mergify Bot added the quantization label Aug 25, 2026

khluu commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Exact hardware validation is terminal green at d2ba916fe024774325baaab418d0af0352b53192:

The original H100-only failure remains https://buildkite.com/vllm/ci/builds/85561#01a03aba-6c3e-4b98-a0f5-40d420e14882: exact test_gsm8k_correctness[Qwen3-30B-A3B-MXFP4A16-humming-act-fp8-block], 0.0000 accuracy / 99.4% invalid outputs against the 0.7800 floor.

This validates the proposed revert; keeping the PR draft for human review. The CI incident remains open until merge plus an exact post-merge main H100 pass.

@mergify

mergify Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @khluu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant