[ROCm][CI] Stabilize MI355 FlyDSL MoE accuracy test - #53024
Merged
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
marked this pull request as ready for review
August 20, 2026 00:49
AndreasKaratzas
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 20, 2026 00:49
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #84715 for commit |
This was referenced Aug 20, 2026
njhill
approved these changes
Aug 21, 2026
am-cohere
pushed a commit
to am-cohere/vllm
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
mikeshawcode
pushed a commit
to mikeshawcode/vllm
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the two MI355 FlyDSL W4A16 MoE cases that failed in AMD CI build 12250. The test was introduced in #44400, and its test, kernel, and conversion code are unchanged between recent passing and failing builds; #41100 changed test collection and exposed the test's dependence on inherited RNG state. The failures contained only a few BF16 accumulation outliers among as many as 117 million output values, so a strict
torch.allclosemade the largest cases brittle. This change seeds the inputs and checks both the mismatch rate and worst normalized error, retaining sensitivity to broad or severe accuracy regressions.atol=0.5, rtol=0.1tolerance, and bound every permitted outlier to 3x its elementwise tolerance.