[ROCm][CI] Extended Fused MoE and FP8 MoE test support#41100
Draft
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Draft
[ROCm][CI] Extended Fused MoE and FP8 MoE test support#41100AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
AndreasKaratzas wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the MoE (Mixture of Experts) testing infrastructure and kernel implementations. Key changes include adding new Buildkite test configurations for AMD hardware, implementing FP4 emulation for ROCm, and improving the MoE layer test runner to handle distributed failures more robustly with temporary failure reports. Additionally, minor adjustments were made to Triton kernel inputs and quantization utilities to ensure compatibility across different platforms. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the fused MoE layer test matrix usable on ROCm/MI355 by fixing the real ModelOpt FP8/FP4 failures it exposes and by making distributed subcase failures visible to pytest.
Key changes:
PASSED.routed_input_transformorgateis requested withoutshared_experts.modelopt_fp4MoE test configs on ROCm and SM90+ paths, where native or emulated NVFP4 execution is available.ops.scaled_fp4_quantis not available there.VLLM_TEST_ENABLE_MORI_MOE_LAYER=1; when enabled, the test sets the AITER fused MoE env requirements and disables AITER shared expert fusion.cc @kenroche