Repository navigation
[Core][PCP] Support data parallelism with MRV2 PCP - #49246
LucasWilkinson wants to merge 2 commits into
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
|
this is very userful pr for prefill , but i want to know , if we can pcp not include in worldsize ? fg : world size not 4 is 2 , only compute tp/pp/dp or only use pcp if setting pcp ,setting tp/pp/dp to 1 ,so worldsize always 8 with pcp 8 @LucasWilkinson refer: |
|
This pull request has merge conflicts that must be resolved before it can be |
Summary
-infLSE before mergingRelated to #46358.
Why this is not a duplicate
I checked issue #46358 and searched open PRs by issue number and DP/PCP/MLA
keywords. No open PR enables generic MRV2 DP+PCP composition. #49109 is scoped to
Mooncake KV-connector PCP replica selection, while #43809 is model-specific
DeepSeek-V4 hybrid-KV/MegaMoE PCP work. Neither changes the generic DP supervisor,
post-PCP DP metadata, or hierarchical AgRs path implemented here.
Validation
Result:
178 passed.Commit-time pre-commit hooks passed, including Ruff, formatting, mypy, SPDX,
configuration validation, and forbidden-import checks.
Runtime configuration (4 GPUs):
Both DP ranks returned the expected answer (
18) when addressed withX-data-parallel-rank.100-sample GSM8K smoke evaluation:
The same rank-pinned runtime probe passed with
VLLM_GPU_SYNC_CHECK=error, withno synchronization detected during model execution.
AI assistance
AI assistance was used to diagnose and implement this draft. This PR should
remain a draft until the human submitter reviews every changed line, confirms
the test/evaluation results, and can explain and defend the change end-to-end.