Conversation
Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
Assisted-by: OpenAI Codex Signed-off-by: jiahanc <173873397+jiahanc@users.noreply.github.com>
|
Hey @jiahanc, do you intend to continue working on this PR. This is something which would be really useful for improving vllm start engine time ... and help with autoscaling etc. Thank you for working on it. Nevermind you mentioned you need flash infer bump |
Contributor
|
@nehashah-eng Yes, we will reopen this with flashinfer 0.16.0, which has the feature needed. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need flashinfer version update
Purpose
Distributed FlashInfer autotuning currently disables the persistent cache and reruns tuning on every server startup. Ranks also profile tactics independently, so GPU timing noise can cause them to select different tactics.
flashinfer-ai/flashinfer#3187 adds
set_autotune_process_group, which averages tactic timings across ranks so all ranks select the same tactic.This PR wires that API into vLLM:
finallyblock.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://docs.vllm.ai/en/latest/contributing (anything written below this line will be removed by GitHub Actions)