Skip to content

[Test][kv_offload] Fix flaky drain() helper in test_fs_tier.py #48545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orozery merged 1 commit into from
Jul 15, 2026
Merged

[Test][kv_offload] Fix flaky drain() helper in test_fs_tier.py #48545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions tests/v1/kv_offload/tiering/test_fs_tier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,10 @@ def make_job(
)


def drain(tier: FileSystemTierManager, max_rounds: int = 100) -> list:
"""
Call get_finished_jobs() repeatedly until no new results arrive for 20
consecutive rounds or max_rounds is reached.
"""
results = []
idle = 0
for _ in range(max_rounds):
time.sleep(0.01)
new = list(tier.get_finished_jobs())
results.extend(new)
if new:
idle = 0
else:
idle += 1
if idle >= 20:
break
return results
def drain(tier: FileSystemTierManager) -> list:
"""Block until all in-flight jobs finish, then collect results."""
tier.drain_jobs()
return list(tier.get_finished_jobs())


def lookup_and_wait(
Expand Down
Loading