[Test][kv_offload] Fix flaky drain() helper in test_fs_tier.py - #48545
Merged
Merged
Conversation
Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
The new code will cause possible hang instead of expected failure? |
orozery
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
drain()test helper intest_fs_tier.pyused a polling loop that exited early after 20 consecutive empty rounds (200 ms). Under a loaded system, store tasks could complete after the 200 ms window, causingtest_load_job_emits_no_eventandtest_partially_failed_store_emits_no_eventto fail withassert 0 == 1.Fix
Replace the polling loop with
tier.drain_jobs()(which callswait_idle()and blocks until all in-flight tasks truly finish) followed by a singleget_finished_jobs()call. This is both simpler and race-condition-free.