Repository navigation
[CI] Fix Transformers modeling backend LoRA test - #47832
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
hmellor
changed the title
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
enabled auto-merge (squash)
July 7, 2026 07:23
github-actions
Bot
added
the
ready
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Isotr0py
approved these changes
Jul 7, 2026
github-project-automation
Bot
moved this from Todo
to Done
in Transformers modeling backend
khluu
pushed a commit
that referenced
this pull request
Jul 8, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> (cherry picked from commit 0ed05b6)
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Jul 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As identified in #47804, #47187 added a new attribute to
QKVParallelLinearfor thesplitoperation that is added as part of Transformers backend fusion. This new attribute was not copied over by LoRA wrapping classes which caused a test failure.This PR removes the need for this new attribute as all the necessary information is already contained in
QKVParallelLinear.output_sizesandQKVParallelLinear.tp_size. It does add a minor performance hit in eager mode, but since the values are constants they are compiled away when compile is enabled.Supersedes #47804 and #47824