Skip to content

[CI][LoRA] Preserve QKV fuser split sizes through LoRA wrappers - #47804

Closed
AndreasKaratzas wants to merge 1 commit into
vllm-project:mainfrom
ROCm:akaratza_fix_lora
Closed

AndreasKaratzas wants to merge 1 commit into
vllm-project:mainfrom
ROCm:akaratza_fix_lora

Conversation

@AndreasKaratzas

Copy link
Copy Markdown
Member

This PR fixes the LoRA regression in CI:

The regression was probably introduced by:

After transformers QKV fuser it rewrites separate q_proj, k_proj, and v_proj calls into one fused qkv_proj call, then splits the fused output with qkv_proj.split_sizes. It sets split_sizes on the generated QKVParallelLinear, but the LoRA wrapper did not preserve that dynamic attribute. When test_ilama_lora initialized the Transformers backend with LoRA enabled, the rewritten forward referenced MergedQKVParallelLinearWithLoRA.split_sizes and failed during engine startup.

Signed-off-by: Andreas Karatzas <akaratza@amd.com>
@AndreasKaratzas
AndreasKaratzas marked this pull request as ready for review July 7, 2026 02:30

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 7, 2026
@tjtanaa
tjtanaa requested a review from hmellor July 7, 2026 04:16
@hmellor

hmellor commented Jul 7, 2026

Copy link
Copy Markdown
Member

I'll look at this ASAP

@hmellor

hmellor commented Jul 7, 2026

Copy link
Copy Markdown
Member

The cause is correct, but I think we should use a different solution. I shouldn't have patched an attribute onto QKVParallelLinear as it is brittle in cases like these. I would push an alternative but the PR was made from an org fork so I can't. I'll make a separate PR

@hmellor hmellor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking in the meantime

@hmellor

hmellor commented Jul 7, 2026

Copy link
Copy Markdown
Member

Here is my PR #47832

@hmellor hmellor closed this Jul 7, 2026
@AndreasKaratzas
AndreasKaratzas deleted the akaratza_fix_lora branch July 8, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants