Repository navigation
[CI][LoRA] Preserve QKV fuser split sizes through LoRA wrappers - #47804
Closed
AndreasKaratzas wants to merge 1 commit into
Closed
AndreasKaratzas wants to merge 1 commit into
AndreasKaratzas wants to merge 1 commit into
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
marked this pull request as ready for review
July 7, 2026 02:30
Member
|
I'll look at this ASAP |
4 tasks
Isotr0py
approved these changes
Jul 7, 2026
Member
|
The cause is correct, but I think we should use a different solution. I shouldn't have patched an attribute onto |
Member
|
Here is my PR #47832 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the LoRA regression in CI:
The regression was probably introduced by:
After transformers QKV fuser it rewrites separate
q_proj,k_proj, andv_projcalls into one fusedqkv_projcall, then splits the fused output withqkv_proj.split_sizes. It setssplit_sizeson the generatedQKVParallelLinear, but the LoRA wrapper did not preserve that dynamic attribute. Whentest_ilama_lorainitialized the Transformers backend with LoRA enabled, the rewritten forward referencedMergedQKVParallelLinearWithLoRA.split_sizesand failed during engine startup.