Repository navigation
[Bugfix][Tool Parser] PoolsideV1: fix string whitespace and required named tool choice - #46486
Merged
sfeng33 merged 3 commits intoJun 26, 2026
Merged
Conversation
…named tool choice extract_tool_calls stripped string-typed args, corrupting content whose whitespace matters (e.g. code/file bodies). required/named tool choice forced JSON guided decoding that conflicts with the XML tool-call format, leaking the call as content with empty tool_calls. Keep string values verbatim, and skip the forced JSON for required/named so the model emits its native XML. Adds tests/tool_parsers/test_poolside_v1_tool_parser.py. Signed-off-by: Joe Rowell <joerowell4@gmail.com>
joerowell
requested review from
aarnphm,
bbrowning,
chaunceyjiang and
sfeng33
as code owners
June 23, 2026 11:33
sfeng33
reviewed
Jun 23, 2026
Member
|
Not a blocking comment for this PR, but sth to consider is: It can be done via adding a Poolside ParserEngineConfig + register an adapter (mirror glm47_moe_config). |
With supports_required_and_named=False, required/named Responses tool calls route into extract_tool_calls, where tools are flat FunctionTool (.name) not nested (.function.name). Resolve via getattr so both shapes work. Adds a Responses extraction regression test. Signed-off-by: Joe Rowell <joerowell4@gmail.com>
sfeng33
approved these changes
Jun 24, 2026
sfeng33
enabled auto-merge (squash)
June 24, 2026 18:08
github-actions
Bot
added
the
ready
wincent8
pushed a commit
to wincent8/vllm
that referenced
this pull request
Jun 29, 2026
…named tool choice (vllm-project#46486) Signed-off-by: Joe Rowell <joerowell4@gmail.com>
4 tasks
philippesic
pushed a commit
to philippesic/vllm-semantic-cache
that referenced
this pull request
Jul 19, 2026
…named tool choice (vllm-project#46486) Signed-off-by: Joe Rowell <joerowell4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR brings some internal fixes for the PoolsideV1 tool parser into mainline vLLM. The main differences are that we handle the XML tags properly even if JSON is requested, and we handle whitespace more intelligently.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.