Skip to content

[Hardware][AMD][CI] Fix Kernels Attention test groups - #46080

Merged
AndreasKaratzas merged 5 commits into
vllm-project:mainfrom
mawong-amd:mawong/fix-kernels-attn-gfx942
Jun 21, 2026
Merged

AndreasKaratzas merged 5 commits into
vllm-project:mainfrom
mawong-amd:mawong/fix-kernels-attn-gfx942

Conversation

@mawong-amd

@mawong-amd mawong-amd commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR fixes both the gfx942 and gfx950-based Kernels Attention test groups. This PR is a re-do of #45786 with a different source branch, as that PR had merge conflicts but is based on a source branch that can no longer be written to.

The following 3 test groups are now newly passing in AMD CI:
MI300_1: Kernels Attention %N
MI355_1: Kernels Attention %N
MI355_1: Kernels (B200-MI355)

Test Plan

pytest -sv tests/kernels/attention on both gfx942 and gfx950-based machines.

Test Result

The test groups pass. They are run as part of AMD CI.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Jun 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jun 18, 2026
@AndreasKaratzas AndreasKaratzas added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 18, 2026
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
…t_prefix_prefill

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
@mawong-amd
mawong-amd force-pushed the mawong/fix-kernels-attn-gfx942 branch from e17c5e5 to a29cb0c Compare June 21, 2026 02:14
@mawong-amd
mawong-amd requested a review from tjtanaa as a code owner June 21, 2026 02:14
@mawong-amd

Copy link
Copy Markdown
Contributor Author

Updated tests/kernels/attention/test_rocm_triton_attn_dsv4.py to bring test_sparse_attn_decode_ragged_kernel in line with the changes in #45681, where the extra cache has data in OCP FP8 format for all platforms.

@AndreasKaratzas AndreasKaratzas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution.

@AndreasKaratzas
AndreasKaratzas merged commit 4f0d004 into vllm-project:main Jun 21, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jun 21, 2026
@mawong-amd
mawong-amd deleted the mawong/fix-kernels-attn-gfx942 branch June 22, 2026 06:29
nkzhenhua pushed a commit to nkzhenhua/vllm that referenced this pull request Jun 24, 2026
…6080)

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
…6080)

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants