Skip to content

[Hardware][AMD][CI] Fix Kernels Attention test groups - #45786

Closed
mawong-amd wants to merge 5 commits into
vllm-project:mainfrom
ROCm:mawong/fix-kernels-attn-gfx942
Closed

mawong-amd wants to merge 5 commits into
vllm-project:mainfrom
ROCm:mawong/fix-kernels-attn-gfx942

Conversation

@mawong-amd

@mawong-amd mawong-amd commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR fixes both the gfx942 and gfx950-based Kernels Attention test groups.

The following 3 test groups are now newly passing in AMD CI:
MI300_1: Kernels Attention %N
MI355_1: Kernels Attention %N
MI355_1: Kernels (B200-MI355)

Test Plan

pytest -sv tests/kernels/attention on both gfx942 and gfx950-based machines.

Test Result

The test groups pass. They are run as part of AMD CI here.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@tjtanaa tjtanaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will come back and check the AMD CI status.

Kernels Attention Test %N (mi300)
Kernels Attention Test %N (mi355)
Kernels (B200-MI355)

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 16, 2026
@mawong-amd mawong-amd changed the title [Hardware][AMD][CI] Fix MI300 Kernels Attention test group [Hardware][AMD][CI] Fix Kernels Attention test group Jun 16, 2026
@mawong-amd mawong-amd changed the title [Hardware][AMD][CI] Fix Kernels Attention test group [Hardware][AMD][CI] Fix Kernels Attention test groups Jun 16, 2026
@mawong-amd

Copy link
Copy Markdown
Contributor Author

Added the remaining fixes needed for MI355_1: Kernels Attention %N and MI355_1: Kernels (B200-MI355) to pass (previously was limited to just MI300_1: Kernels Attention %N) and triggered the relevant test groups.

@mawong-amd
mawong-amd force-pushed the mawong/fix-kernels-attn-gfx942 branch from 0259374 to 5e16de9 Compare June 16, 2026 19:43
@mergify mergify Bot added the ci/build label Jun 16, 2026
@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Hi @mawong-amd, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Comment thread .buildkite/test-amd.yaml
Comment thread .buildkite/test_areas/kernels.yaml Outdated
@mawong-amd
mawong-amd force-pushed the mawong/fix-kernels-attn-gfx942 branch from 5e16de9 to bf2da0e Compare June 16, 2026 22:29
@tjtanaa

tjtanaa commented Jun 17, 2026

Copy link
Copy Markdown
Member

@mawong-amd can you sync with main again. It seems the error is gone in latest nightly https://buildkite.com/vllm/ci/builds/72616/list

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
…t_prefix_prefill

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
@mawong-amd
mawong-amd force-pushed the mawong/fix-kernels-attn-gfx942 branch from bf2da0e to 70dbd60 Compare June 17, 2026 15:12
@mawong-amd

Copy link
Copy Markdown
Contributor Author

The remaining error in H100 batch invariance appears unrelated to this PR

@mergify

mergify Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mawong-amd.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mawong-amd

Copy link
Copy Markdown
Contributor Author

Closing in favor of #46080 because this PR has merge conflicts which can no longer be resolved, since the source branch is no longer writeable.

@mawong-amd mawong-amd closed this Jun 18, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jun 18, 2026
@mawong-amd
mawong-amd deleted the mawong/fix-kernels-attn-gfx942 branch June 25, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build needs-rebase ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants