[CI] Restore MiniCPMV transformers cap, scoped to HF runner only - #45042
Merged
Merged
Conversation
hmellor
requested review from
AndreasKaratzas,
DarkLight1337 and
ywang96
as code owners
June 9, 2026 16:32
DarkLight1337
approved these changes
Jun 9, 2026
DarkLight1337
enabled auto-merge (squash)
June 9, 2026 16:34
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
vllm-project#48413 fixed the vLLM-side `MiniCPMVBatchFeature` incompatibility and dropped the `max_transformers_version` cap on `MiniCPMV` entirely. That also un-gated the tests that build an HF reference model, exposing a separate HF-side break: MiniCPMV's remote code never calls `self.post_init()`, so `all_tied_weights_keys` is never set and Transformers v5 raises in `_move_missing_keys_from_meta_to_device`. Restore the cap with an `hf`-scoped reason so HF-runner comparisons skip while vLLM-only coverage keeps running. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
force-pushed
the
enable-minicpmv-ci
branch
from
August 11, 2026 15:06
7cb6fe1 to
7f92af5
Compare
MiniCPMV for vLLM in CI
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #83373 for commit |
zyp2014
pushed a commit
to zyp2014/vllm
that referenced
this pull request
Aug 21, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restores the
max_transformers_versioncap on theMiniCPMVtest registry entry, scoped to the HF runner only (transformers_version_reason={"hf": ...}).This PR previously flipped an existing
"vllm"reason to"hf". Since then #48413 removed the cap outright, so it has been rewritten: the cap is re-added, with the correct reason.Why the cap is needed again
Nightly build 83094 (
Multi-Modal Models (Extended Generation 3), anoptional: truestep that only runs in the scheduled full CI run) fails 9 tests, all with:test_single_image_models[minicpmv_25-test_case100..102]test_single_image_models[minicpmv_26-test_case103..105]test_multi_image_models[minicpmv_26-test_case77..79]The failure is entirely on the HF reference side. The traceback ends in
transformers/modeling_utils.py:all_tied_weights_keysis set byPreTrainedModel.post_init(), and MiniCPMV's remote code never calls it:post_initappears zero times inmodeling_minicpmv.pyforMiniCPM-Llama3-V-2_5,MiniCPM-V-4andMiniCPM-V-4_5(2_6 is gated on the Hub now, but fails identically). Same failure mode asSkyworkR1VChatModel(#42104) and the siblingMiniCPMOentry, both already capped.Why it surfaced now
The
MiniCPMVentry used to carrymax_transformers_version="4.57"with a"vllm"reason. Becausevlm_utils/core.py::run_testcallscheck_transformers_version(on_fail="skip")with the defaultcheck_max_version=True, that cap gated the HF-runner tests too. #48413 fixed the vLLM-sideMiniCPMVBatchFeatureproblem and removed the cap entirely, which correctly re-enabled vLLM-only coverage but also un-gated the HF comparisons and exposed this separate, still-unfixed HF-side break.Using an
"hf"-scoped reason keeps both halves right: HF-runner comparisons skip, vLLM-only tests (including the ones #48413 added intests/models/multimodal/processing/test_minicpmv.py) keep running, because those callers passcheck_max_version=False, check_version_reason="vllm".Tracks under #38379.
Not a duplicate
This is the pre-existing PR for this fix, rewritten rather than superseded by a new one. Duplicate checks run:
No other open PR touches the
MiniCPMVregistry entry. #43760 and #42785 are runtime/CUDA-graph changes to the model itself.Testing
The two failures (
test_registry_imports[HCXVisionForCausalLM],test_registry_imports[KananaVForConditionalGeneration]) are pre-existing and unrelated: confirmed by re-running them on a stashed tree.Behaviour of the gate itself, against
transformers==5.16.0.dev0:All four variants skip HF-runner tests and none skip vLLM-only tests, which is the intended split.
No model evaluation results: this is a test-gating change only, with no effect on model output, accuracy or serving.
AI assistance
AI assistance was used for this change (investigating the Buildkite failure, bisecting the cause to #48413, and drafting the patch and this description). I have reviewed every changed line and run the tests reported above.