[CI] set max transformers version for skywork model - #42104
Conversation
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
There was a problem hiding this comment.
Code Review
This pull request updates the SkyworkR1VChatModel registry entry in tests/models/registry.py to cap the transformers version at 4.57. The reviewer identified that including the transformers_version_reason field causes tests to be skipped unconditionally, which would unintentionally disable test coverage for compatible v4.x versions. It is recommended to remove the transformers_version_reason entry to ensure tests continue to run on supported versions while still enforcing the version cap.
| transformers_version_reason={ | ||
| "hf": ( | ||
| "SkyworkChatModel.__init__ does not call self.post_init(), so " | ||
| "`all_tied_weights_keys` is never set; Transformers v5 requires " | ||
| "this attribute in _move_missing_keys_from_meta_to_device." | ||
| ) | ||
| }, | ||
| ), |
There was a problem hiding this comment.
In the current implementation of check_transformers_version (lines 158-163), providing a key in transformers_version_reason (like "hf") causes the corresponding tests to be skipped unconditionally, regardless of whether the version requirement is met.
Since your reason string indicates that the issue is specific to transformers v5, adding this entry will unintentionally disable HF runner tests for Skywork on all versions, including v4.x. If you want to maintain test coverage for v4.x, you should omit the transformers_version_reason entry. The max_transformers_version="4.57" setting alone is sufficient to skip the tests on v5.x with a clear version-mismatch message.
),Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
This PR resolves the following error:
The failure occurs because of change in
transformers 5.xAPIs which introducedall_tied_weights_keysIn transformers 5.x post_init() now sets an instance attribute all_tied_weights_keys (a dict):
This PR resolves the following tests as shown in this AMD CI run
Related AMD CI issue: #42020 (comment)