[BugFix] Fix sparse NCCL weight transfer test construction#44345
Merged
robertgshaw2-redhat merged 1 commit intoJun 2, 2026
Merged
Conversation
Signed-off-by: Siddharth Bedekar <bedeksid@gmail.com>
robertgshaw2-redhat
approved these changes
Jun 2, 2026
bnellnm
approved these changes
Jun 2, 2026
Contributor
|
Documentation preview: https://vllm--44345.org.readthedocs.build/en/44345/ |
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Siddharth Bedekar <bedeksid@gmail.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
bnellnm
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Siddharth Bedekar <bedeksid@gmail.com>
andakai
pushed a commit
to andakai/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Siddharth Bedekar <bedeksid@gmail.com>
JisoLya
pushed a commit
to JisoLya/vllm
that referenced
this pull request
Jun 5, 2026
Signed-off-by: Siddharth Bedekar <bedeksid@gmail.com> Signed-off-by: JisoLya <523420504@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #44272 forward for the tests that failed in the nightly CI.
The production path already passes the model through WeightTransferEngineFactory.create_engine(...); the breakage was in stale test/example-style call sites that still constructed NCCLWeightTransferEngine(config, parallel_config) directly which run only when >2 GPUs.
This updates:
Test Plan
Test Result