Revert "[Frontend][Core] Add sparse NCCL weight transfer support for in-place updates" (#40096)#44272
Closed
vllm-agent wants to merge 1 commit into
Closed
Revert "[Frontend][Core] Add sparse NCCL weight transfer support for in-place updates" (#40096)#44272vllm-agent wants to merge 1 commit into
vllm-agent wants to merge 1 commit into
Conversation
…in-place updates (vllm-project#40096)" This reverts commit 266b9d9.
Contributor
|
Documentation preview: https://vllm--44272.org.readthedocs.build/en/44272/ |
mergify
Bot
added
documentation
Contributor
|
The issue is in the test only. I'll create a pr to fix forward. |
Member
|
Thanks @bedeks! Let's fast-track it |
Member
|
Closing in favor of #44345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of #40096
Reason: This PR introduced a new failure in nightly CI build #69310.
Failed test:
Distributed Tests (2 GPUs)(H100)—NCCLWeightTransferEngine.__init__() missing 1 required positional argument: 'model'intests/distributed/test_weight_transfer.pyFailure count: 1 new test failure linked to this PR.
Auto-generated by CI failure analyzer — build #69310