Skip to content

[Bugfix] Fix integer overflow in libtorch_stable/activation_kernels.cu pointer arithmetic #44026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dparikh79 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −6
Open

[Bugfix] Fix integer overflow in libtorch_stable/activation_kernels.cu pointer arithmetic #44026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions csrc/libtorch_stable/activation_kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,11 @@ __global__ void act_and_mul_kernel(
scalar_t* __restrict__ out, // [..., d]
const scalar_t* __restrict__ input, // [..., 2, d]
const int d, const float limit) {
const scalar_t* x_ptr = input + blockIdx.x * 2 * d;
// Promote blockIdx.x to int64_t before multiplying by 2 * d (#42860).
const int64_t token_idx = blockIdx.x;
const scalar_t* x_ptr = input + token_idx * 2 * d;
const scalar_t* y_ptr = x_ptr + d;
scalar_t* out_ptr = out + blockIdx.x * d;
scalar_t* out_ptr = out + token_idx * d;

if constexpr (use_vec) {
using cuda_t = typename CUDATypeConverter<scalar_t>::Type;
Expand Down Expand Up @@ -317,9 +319,10 @@ template <typename scalar_t, typename packed_t,
__global__ void act_and_mul_kernel_with_param(
scalar_t* __restrict__ out, const scalar_t* __restrict__ input, const int d,
const float param) {
const scalar_t* x_ptr = input + blockIdx.x * 2 * d;
const int64_t token_idx = blockIdx.x;
const scalar_t* x_ptr = input + token_idx * 2 * d;
const scalar_t* y_ptr = x_ptr + d;
scalar_t* out_ptr = out + blockIdx.x * d;
scalar_t* out_ptr = out + token_idx * d;

if constexpr (use_vec) {
using cuda_t = typename CUDATypeConverter<scalar_t>::Type;
Expand Down Expand Up @@ -526,8 +529,9 @@ __global__ void activation_kernel(
scalar_t* __restrict__ out, // [..., d]
const scalar_t* __restrict__ input, // [..., d]
const int d) {
const scalar_t* in_ptr = input + blockIdx.x * d;
scalar_t* out_ptr = out + blockIdx.x * d;
const int64_t token_idx = blockIdx.x;
const scalar_t* in_ptr = input + token_idx * d;
scalar_t* out_ptr = out + token_idx * d;

if constexpr (use_vec) {
// Fast path: 128-bit/256-bit vectorized loop
Expand Down
Loading