-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Allow LMCacheConnectorV1 to support hybrid KV loads #42620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avifenesh
wants to merge
3
commits into
vllm-project:main
Choose a base branch
from
avifenesh:avi/qwen-lmcache-hma
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−1
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method might get picked up as dead code.
We should either comment that it's being used externally or use the property kv_cache_config directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in
8b58c3ed5d: I removed the LMCache-specific getter and exposed the config through the connector attribute instead.vLLM side:
LMCacheConnectorV1.__init__now setsself.kv_cache_config = kv_cache_configget_lmcache_kv_cache_config()was removedCompanion LMCache side is updated in
LMCache/LMCache#3284commit6ae3e7f7to readparent.kv_cache_configdirectly.Fresh validation:
timeout 60 uvx ruff check vllm/distributed/kv_transfer/kv_connector/v1/lmcache_connector.py tests/v1/kv_connector/unit/test_lmcache_connector.pytimeout 60 uvx ruff format --check vllm/distributed/kv_transfer/kv_connector/v1/lmcache_connector.py tests/v1/kv_connector/unit/test_lmcache_connector.py.venv/bin/python -m py_compile vllm/distributed/kv_transfer/kv_connector/v1/lmcache_connector.py tests/v1/kv_connector/unit/test_lmcache_connector.py.venv/bin/python -m pytest -q tests/v1/kv_connector/unit/test_lmcache_connector.py->26 passed, 16 warningsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickLucche