[Test][Bugfix] Fix mypy error: missing enable_prompt_embeds arg in test_tp_sp_nvfp4_generation#42214
Closed
chfeng-cs wants to merge 1 commit into
Closed
Conversation
…p4_generation tests/compile/correctness_e2e/test_sequence_parallel.py:418 was missing the required positional argument `enable_prompt_embeds` in the call to `_compare_sp`, causing mypy to fail across all Python versions in CI. Signed-off-by: Ethan Feng <ethan.fengch@gmail.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test_tp_sp_nvfp4_generation test case in tests/compile/correctness_e2e/test_sequence_parallel.py by explicitly setting the enable_prompt_embeds parameter to False. There are no review comments to evaluate, and I have no further feedback to provide.
chfeng-cs
changed the title
github-actions
Bot
added
the
ready
Collaborator
|
prefer #42197 |
auto-merge was automatically disabled
May 10, 2026 07:37
Pull request was closed
Contributor
Author
|
Thanks for the clarification — understood that this is a duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a mypy error introduced in #33322, which added the enable_prompt_embeds parameter to _compare_sp but missed updating one call site.
The call in test_tp_sp_nvfp4_generation (line 418) was left without the new required positional argument, causing CI mypy checks to fail across all Python
versions (3.10–3.13).
This PR adds enable_prompt_embeds=False to that call. False is correct here — this is a plain generation test with no multimodal prompt embeddings involved.
This is not a duplicate of any existing open PR.
Test Plan
mypy --python-version 3.10 --follow-imports skip tests
mypy --python-version 3.11 --follow-imports skip tests
mypy --python-version 3.12 --follow-imports skip tests
mypy --python-version 3.13 --follow-imports skip tests
Test Result
All four mypy invocations pass with no errors after the fix.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.