Skip to content

Fix mypy failure on main#42197

Merged
Isotr0py merged 1 commit into
vllm-project:mainfrom
mmangkad:fix-nvfp4-sp-mypy
May 10, 2026
Merged

Fix mypy failure on main#42197
Isotr0py merged 1 commit into
vllm-project:mainfrom
mmangkad:fix-nvfp4-sp-mypy

Conversation

@mmangkad

Copy link
Copy Markdown
Contributor

Purpose

Fixes the mypy failure caused by #33322 making enable_prompt_embeds required in _compare_sp while #41882 added an NVFP4 sequence-parallel test call without passing it

Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mmangkad mmangkad changed the title Fix lint on main Fix mypy failure on main May 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test_tp_sp_nvfp4_generation test case in tests/compile/correctness_e2e/test_sequence_parallel.py by explicitly setting the enable_prompt_embeds parameter to False. I have no feedback to provide as there are no review comments to evaluate.

@Isotr0py Isotr0py enabled auto-merge (squash) May 10, 2026 04:40
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 10, 2026
@SoluMilken

Copy link
Copy Markdown
Contributor

Thanks for the quick fix! This should help keep main clean by unblocking the mypy pre-commit failure that recent commits were inheriting.

@noooop

noooop commented May 10, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the quick fix! This should help keep main clean by unblocking the mypy pre-commit failure that recent commits were inheriting.

This should already be fixed by #41362, but we still need to wait a long time for the accumulated PRs to be updated to the latest code.

@Isotr0py Isotr0py merged commit efd0e77 into vllm-project:main May 10, 2026
19 checks passed
@SoluMilken

Copy link
Copy Markdown
Contributor

This should already be fixed by #41362, but we still need to wait a long time for the accumulated PRs to be updated to the latest code.

Ah, got it! Thanks for the clarification. Fingers crossed the queue clears up soon.

@mmangkad mmangkad deleted the fix-nvfp4-sp-mypy branch May 10, 2026 10:56
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request May 11, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
weifang231 pushed a commit to weifang231/eb-vllm that referenced this pull request May 13, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
mfylcek pushed a commit to mfylcek/vllm that referenced this pull request May 19, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
jhu960213 pushed a commit to jhu960213/vllm that referenced this pull request May 20, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
knight0528 pushed a commit to knight0528/vllm that referenced this pull request Jun 8, 2026
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants