Fix mypy failure on main#42197
Conversation
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
There was a problem hiding this comment.
Code Review
This pull request updates the test_tp_sp_nvfp4_generation test case in tests/compile/correctness_e2e/test_sequence_parallel.py by explicitly setting the enable_prompt_embeds parameter to False. I have no feedback to provide as there are no review comments to evaluate.
|
Thanks for the quick fix! This should help keep main clean by unblocking the mypy pre-commit failure that recent commits were inheriting. |
This should already be fixed by #41362, but we still need to wait a long time for the accumulated PRs to be updated to the latest code. |
Ah, got it! Thanks for the clarification. Fingers crossed the queue clears up soon. |
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Signed-off-by: Mohammad Miadh Angkad <MAngkad.BSDSBA2027@aim.edu>
Purpose
Fixes the mypy failure caused by #33322 making
enable_prompt_embedsrequired in_compare_spwhile #41882 added an NVFP4 sequence-parallel test call without passing it