Skip to content

[Bugfix] restore MLA notif request_id accidentally reverted in #40731 #41975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZhanqiuHu wants to merge 1 commit into from
+1 −1
Closed

[Bugfix] restore MLA notif request_id accidentally reverted in #40731 #41975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/distributed/kv_transfer/kv_connector/v1/nixl/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,7 +1959,7 @@ def _read_blocks_for_req(self, req_id: str, meta: ReqMeta):
if self.use_mla and tp_ratio < 0 and read_specs:
# ..but we still need to notify the other remote ranks that we
# have the blocks we need so they can update the request state.
notif_id = f"{req_id}:{self.world_size}".encode()
notif_id = f"{meta.remote.request_id}:{self.world_size}".encode()
remote_agents = self._remote_agents[meta.remote.engine_id]
read_ranks = {s.remote_rank for s in read_specs}
for rank_to_notify, agent in remote_agents.items():
Expand Down
Loading