[Bugfix] restore MLA notif request_id accidentally reverted in #40731#41975
Closed
ZhanqiuHu wants to merge 1 commit into
Closed
[Bugfix] restore MLA notif request_id accidentally reverted in #40731#41975ZhanqiuHu wants to merge 1 commit into
ZhanqiuHu wants to merge 1 commit into
Conversation
…roject#40731 PR vllm-project#40449 fixed the MLA broadcast notification to use `meta.remote.request_id` (the prefill-side id) instead of `req_id` (the decode-side id). The refactor in vllm-project#40731 inadvertently reverted this back to `req_id`, causing "Potentially invalid KV blocks for unrecognized request" errors on non-reading P-ranks when P_TP > D_TP. Fixes vllm-project#41974 Signed-off-by: Zhanqiu Hu <zhanqiuhu@gmail.com>
ZhanqiuHu
requested review from
ApostaC,
NickLucche,
orozery and
xuechendi
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the notif_id generation within the _read_blocks_for_req method in the NIXL worker. It ensures that the remote request ID from the metadata is used instead of the local request ID when notifying other ranks in MLA configurations. There were no review comments provided, so I have no feedback to offer.
Contributor
Author
|
duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restore the fix from #40449 that was accidentally reverted during the refactor in #40731.
In
_read_blocks_for_req, when MLA is enabled and P_TP > D_TP, the broadcast notification to non-reading P-ranks was usingreq_id(decode-side) instead ofmeta.remote.request_id(prefill-side). This caused "Potentially invalid KV blocks for unrecognized request" errors and eventual timeout-based block release on skipped P-ranks.Fixes #41974