Skip to content

[CI] Fix failed CI step "PyTorch Compilation Unit Tests"#41959

Closed
SoluMilken wants to merge 3 commits intovllm-project:mainfrom
SoluMilken:fix/always-hit-shape-env-missing-var-to-hint-override
Closed

[CI] Fix failed CI step "PyTorch Compilation Unit Tests"#41959
SoluMilken wants to merge 3 commits intovllm-project:mainfrom
SoluMilken:fix/always-hit-shape-env-missing-var-to-hint-override

Conversation

@SoluMilken
Copy link
Copy Markdown
Contributor

@SoluMilken SoluMilken commented May 7, 2026

Purpose

Fix 41958.

Test Plan

python -m pytest tests/compile/test_aot_compile.py

Test Result

image
Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

SoluMilken added 2 commits May 7, 2026 21:49
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
@SoluMilken SoluMilken force-pushed the fix/always-hit-shape-env-missing-var-to-hint-override branch from 6a6990e to 50299c6 Compare May 7, 2026 13:49
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error reporting for test subprocesses by including both stdout and stderr in the failure message and using robust decoding to handle potential encoding issues. Additionally, it initializes a new dictionary, var_to_hint_override, in the AlwaysHitShapeEnv class. Feedback was provided to eliminate redundant output in the error message when a traceback file is missing by using a placeholder instead of duplicating the stderr content.

Comment thread tests/utils.py Outdated
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
@SoluMilken SoluMilken marked this pull request as ready for review May 7, 2026 14:04
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@SoluMilken SoluMilken changed the title [CI] Fix always hit shape env missing var to hint override [CI Failure] Fix always hit shape env missing var to hint override May 7, 2026
@SoluMilken SoluMilken changed the title [CI Failure] Fix always hit shape env missing var to hint override [CI] Fix 'AlwaysHitShapeEnv' object has no attribute 'var_to_hint_override' May 7, 2026
@SoluMilken SoluMilken changed the title [CI] Fix 'AlwaysHitShapeEnv' object has no attribute 'var_to_hint_override' [CI] Fix "PyTorch Compilation Unit Tests" May 7, 2026
@SoluMilken SoluMilken changed the title [CI] Fix "PyTorch Compilation Unit Tests" [CI] Fix failed CI step "PyTorch Compilation Unit Tests" May 7, 2026
@SoluMilken
Copy link
Copy Markdown
Contributor Author

Hi @ProExpertProg,

I saw you just reviewed/approved another CI fix PR. Could you help me take a quick look at this one as well? I'm trying to fix the "PyTorch Compilation Unit Tests" CI failure and would appreciate your guidance to get it passing. Thanks!

@ProExpertProg ProExpertProg added the ready ONLY add when PR is ready to merge/full CI is needed label May 7, 2026
@SoluMilken
Copy link
Copy Markdown
Contributor Author

The issue has been fixed by this PR #41940.
Let me close this PR and this issue #41958.

@SoluMilken SoluMilken closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure] pytorch-compilation-unit-tests: AlwaysHitShapeEnv missing var_to_hint_override

2 participants