[CI][Bugfix] Fix CI failures for "PyTorch Compilation Unit Tests"#41940
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom May 8, 2026
Merged
Conversation
PyTorch 2.11 added a `var_to_hint_override` attribute on `ShapeEnv`, and Inductor's `FxGraphHashDetails.__init__` now reads it unconditionally (`torch/_inductor/codecache.py:939`). vLLM's duck-type mock `AlwaysHitShapeEnv` (used by the legacy `InductorAdaptor` path when `VLLM_USE_STANDALONE_COMPILE=0`) was missing this attribute, which raised `AttributeError` during engine-core init and surfaced as `Server exited unexpectedly` in CI. Add the attribute as an empty dict so the cache-key code short-circuits the override branch, matching the real `ShapeEnv` default. Signed-off-by: haosdent <haosdent@hotmail.com> Signed-off-by: haosdent <haosdent@gmail.com>
haosdent
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AlwaysHitShapeEnv class in vllm/compilation/compiler_interface.py by initializing an empty var_to_hint_override dictionary. This change ensures compatibility with torch>=2.11, where FxGraphHashDetails reads this attribute to incorporate dynamic-shape hint overrides into the cache key. I have no feedback to provide as no review comments were submitted.
haosdent
requested review from
BoyuanFeng,
ProExpertProg,
vadiklyutiy,
youkaichao and
zou3519
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
haosdent
changed the title
haosdent
changed the title
DarkLight1337
added
the
ready
Contributor
Author
|
@dzhengAP Please take a look when you are available, thank you in advance! |
ProExpertProg
approved these changes
May 7, 2026
Collaborator
|
@haosdent failure looks related. Also do you know why we're running with standalone compile = 0? |
Contributor
Author
Collaborator
|
Yeah we should remove it, but let's do that in follow-up, I think we can merge this PR. |
This was referenced May 8, 2026
libinta
pushed a commit
to libinta/vllm
that referenced
this pull request
May 8, 2026
…lm-project#41940) Signed-off-by: haosdent <haosdent@gmail.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
vLLM's duck-type
ShapeEnvmockAlwaysHitShapeEnv(used by the legacyInductorAdaptorpath whenVLLM_USE_STANDALONE_COMPILE=0) was missingvar_to_hint_override.torch._inductor.codecache.FxGraphHashDetailsreads it unconditionally in torch>=2.11, so engine-core init raised
AttributeErrorand surfaced asServer exited unexpectedlyin CI.Fix: add the attribute as an empty dict, matching the real
ShapeEnvdefault.Failed buildkite runs (all on unrelated HEAD commits):
Related to #41423
Test Plan
Test Result