Skip to content

fix(rocm): remove workaround causing invalid argument on Qwen3.5 with TP=2 #40686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 3 commits into from
May 6, 2026
Merged

fix(rocm): remove workaround causing invalid argument on Qwen3.5 with TP=2 #40686

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
387d828
fix(rocm): remove workaround causing invalid argument on Qwen3.5 with…
Apr 23, 2026
c016adf
Merge branch 'main' into fix-rocm-qwen-wakeup
tjtanaa Apr 28, 2026
f994b6a
Merge branch 'main' into fix-rocm-qwen-wakeup
tjtanaa May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions csrc/cumem_allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,28 +232,6 @@ void unmap_and_release(unsigned long long device, ssize_t size,
}
}

// ROCm workaround: hipMemRelease does not return physical VRAM to the
// free pool while the virtual-address reservation is still held.
// Cycling cuMemAddressFree → cuMemAddressReserve (at the same address)
// forces the driver to actually release the physical pages while keeping
// the same VA available for a later create_and_map.
if (first_error == no_error) {
first_error = cuMemAddressFree(d_mem, size);
if (first_error == no_error) {
CUdeviceptr d_mem_new = 0;
first_error = cuMemAddressReserve(&d_mem_new, size, 0, d_mem, 0);
if (first_error == no_error && d_mem_new != d_mem) {
cuMemAddressFree(d_mem_new, size);
snprintf(error_msg, sizeof(error_msg),
"ROCm: VA re-reserve got %p instead of %p", (void*)d_mem_new,
(void*)d_mem);
error_code = CUresult(1);
std::cerr << error_msg << std::endl;
return;
}
}
}

if (first_error != no_error) {
CUDA_CHECK(first_error);
}
Expand Down
Loading