fix(rocm): remove workaround causing invalid argument on Qwen3.5 with TP=2#40686
Merged
Conversation
Contributor
|
Hi @aaab8b, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Contributor
Author
|
using this script and rocm can reproduce this problem: if name == 'main': |
chaojun-zhang
pushed a commit
to chaojun-zhang/vllm
that referenced
this pull request
May 6, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com>
ikaadil
pushed a commit
to ikaadil/vllm
that referenced
this pull request
May 7, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com> Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
libinta
pushed a commit
to libinta/vllm
that referenced
this pull request
May 8, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com> Signed-off-by: Libin Tang <libin.tang@intel.com>
weifang231
pushed a commit
to weifang231/eb-vllm
that referenced
this pull request
May 13, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com>
mfylcek
pushed a commit
to mfylcek/vllm
that referenced
this pull request
May 19, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
… TP=2 (vllm-project#40686) Co-authored-by: Test User <test@example.com> Co-authored-by: TJian <tunjian.tan@embeddedllm.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a ROCm workaround in
cumem_allocator.cpp. Keeping this code causes aninvalid argumenterror duringwake_upfor the Qwen3.5 model when running withTP=2on ROCm platforms.