Skip to content

[CI/Build] Apply ruff formatter to pass pre-commit#40078

Merged
jikunshang merged 1 commit intovllm-project:mainfrom
pfnet:apply-ruff-format
Apr 17, 2026
Merged

[CI/Build] Apply ruff formatter to pass pre-commit#40078
jikunshang merged 1 commit intovllm-project:mainfrom
pfnet:apply-ruff-format

Conversation

@Alnusjaponica
Copy link
Copy Markdown
Contributor

@Alnusjaponica Alnusjaponica commented Apr 16, 2026

Purpose

Fix the pre-commit CI pipeline on the main branch.

The pre-commit CI has been failing since commit 29057d3, which is currently blocking new PRs from being auto-merged. This PR resolves those issues.

Test Plan

  • Verify that the pre-commit CI passes on this PR.
  • (Optional) Successfully run pre-commit run --all-files locally.

Test Result

git commit -s -m "Apply ruff formatter to pass pre-commit"
ruff check..........................................................................................Passed
ruff format.........................................................................................Passed
typos...............................................................................................Passed
clang-format....................................................................(no files to check)Skipped
markdownlint-cli2...............................................................(no files to check)Skipped
Lint GitHub Actions workflow files..............................................(no files to check)Skipped
pip-compile.....................................................................(no files to check)Skipped
pip-compile-rocm................................................................(no files to check)Skipped
pip-compile-xpu.................................................................(no files to check)Skipped
reformat test/nightly-torch.txt to be in sync with test/cuda.in.................(no files to check)Skipped
Run mypy locally for lowest supported Python version................................................Passed
Lint shell scripts..............................................................(no files to check)Skipped
Lint PNG exports from excalidraw................................................(no files to check)Skipped
Check SPDX headers..................................................................................Passed
Check root lazy imports.............................................................................Passed
Check for spaces in all filenames...................................................................Passed
Update Dockerfile dependency graph..................................................................Passed
Check for forbidden imports.........................................................................Passed
Prevent new 'torch.cuda' APIs call..................................................................Passed
Validate configuration has default values and that each field has a docstring.......................Passed
Validate docker/versions.json matches Dockerfile................................(no files to check)Skipped
Check attention backend documentation is up to date.................................................Passed
Check for boolean ops in with-statements............................................................Passed
Suggestion..........................................................................................Passed
- hook id: suggestion
- duration: 0s

To bypass all the pre-commit hooks, add --no-verify to git commit. To skip a specific hook, prefix the commit command with SKIP=<hook-id>.

Sign-off Commit..........................................................Passed
- hook id: signoff-commit
- duration: 0.01s
[apply-ruff-format 264fbdbbe] Apply ruff formatter to pass pre-commit
 1 file changed, 3 insertions(+), 5 deletions(-)

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs minor code cleanup in the test_vllm_fusion_pattern_matcher_pass.py file, including reordering imports, removing redundant blank lines, and fixing a PEP 8 spacing issue in a variable assignment. I have no feedback to provide.

@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed ci-failure Issue about an unexpected test failure in CI labels Apr 16, 2026
@mgoin
Copy link
Copy Markdown
Member

mgoin commented Apr 16, 2026

@ProExpertProg

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 16, 2026

Hi @Alnusjaponica, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Copy link
Copy Markdown
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, not sure how this got through, thx for fixing!

@jikunshang jikunshang merged commit 4c47710 into vllm-project:main Apr 17, 2026
23 of 24 checks passed
@Alnusjaponica Alnusjaponica deleted the apply-ruff-format branch April 17, 2026 01:02
bnellnm pushed a commit to neuralmagic/vllm that referenced this pull request Apr 20, 2026
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
whk-lab pushed a commit to whk-lab/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Apr 27, 2026
Signed-off-by: Hemmi Shinichi <shemmi@preferred.jp>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-failure Issue about an unexpected test failure in CI ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants