[XPU] enable is_act_and_mul for xpu#37481
[XPU] enable is_act_and_mul for xpu#37481xuechendi wants to merge 3 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request enables is_act_and_mul=False for XPU platforms in FusedMoE layers. The change correctly adds current_platform.is_xpu() to the supported platforms check. I have one suggestion to improve the clarity of an error message related to this change.
| if not self.moe_config.is_act_and_mul and not ( | ||
| current_platform.is_cuda_alike() or current_platform.is_xpu() | ||
| ): |
There was a problem hiding this comment.
Since this change adds support for XPU when is_act_and_mul=False, the NotImplementedError message raised within this if block is now outdated. It would be beneficial to update it to include 'XPU' to avoid confusion for future developers. For example: "is_act_and_mul=False is supported only for CUDA, ROCm, and XPU for now".
|
better mark as draft for now since we need vllm-xpu-kernel dependency/ |
|
actually I think we can merge this firstly, since it will assert in vllm-xpu-kernels side. |
|
This pull request has merge conflicts that must be resolved before it can be |
|
@jikunshang , Since this PR will need main branch of vllm-xpu-kernels instead 0.1.5. |
|
Hi @xuechendi, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
@xuechendi we will have next vllm-xpu-kernel release this weedkend or next Monday, then I will merge this. |
133439a to
2ca3d18
Compare
Signed-off-by: Chendi Xue <chendi.xue@intel.com>
|
Hi @xuechendi, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
2ca3d18 to
ff47abf
Compare
|
Hi @xuechendi, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
pre commit fixed in #40078 |
|
v0.1.7 bump up PR is here #41019. please rebase after it merged. thanks. |
Purpose
Testing
nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-bf16on XPU and enablerelu2_no_muldependencies:
Test Plan
Test Result
Accuracy meet requirement in https://github.com/vllm-project/vllm/blob/main/.buildkite/lm-eval-harness/configs/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16.yaml
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.