Skip to content

Fix TURBOQUANT backend selection in cuda.py#40060

Merged
vllm-bot merged 2 commits intomainfrom
fix-tq-selection
Apr 17, 2026
Merged

Fix TURBOQUANT backend selection in cuda.py#40060
vllm-bot merged 2 commits intomainfrom
fix-tq-selection

Conversation

@mgoin
Copy link
Copy Markdown
Member

@mgoin mgoin commented Apr 16, 2026

Purpose

Added TURBOQUANT to the selection list of attention backends and removed specialized case.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Added TURBOQUANT to the list of attention backends and removed specialized TurboQuant KV cache handling.

Signed-off-by: Michael Goin <mgoin64@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates TURBOQUANT into the standard attention backend priority lists for CUDA platforms while removing the previous hardcoded bypass for TurboQuant KV cache types. Feedback indicates that moving TURBOQUANT to the end of the priority list is a regression that could lead to incorrect backend selection; it is recommended to use the kv_cache_dtype parameter to prioritize TURBOQUANT when explicitly requested while still allowing for standard validation.

Comment thread vllm/platforms/cuda.py
@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed labels Apr 16, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 16, 2026

Hi @mgoin, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@mgoin mgoin changed the title Fix TURBOQUANT backend selection Fix TURBOQUANT backend selection in cuda.py Apr 16, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 16, 2026

Hi @mgoin, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: Michael Goin <mgoin64@gmail.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 16, 2026

Documentation preview: https://vllm--40060.org.readthedocs.build/en/40060/

@mergify mergify Bot added the documentation Improvements or additions to documentation label Apr 16, 2026
@vllm-bot vllm-bot merged commit 1174723 into main Apr 17, 2026
50 of 53 checks passed
@vllm-bot vllm-bot deleted the fix-tq-selection branch April 17, 2026 14:31
@github-project-automation github-project-automation Bot moved this to Done in NVIDIA Apr 17, 2026
bnellnm pushed a commit to neuralmagic/vllm that referenced this pull request Apr 20, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
whk-lab pushed a commit to whk-lab/vllm that referenced this pull request Apr 23, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Apr 27, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants