Fix pre-commit labeled trigger system#39523
Merged
Merged
Conversation
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
DarkLight1337
approved these changes
Apr 10, 2026
DarkLight1337
left a comment
DarkLight1337
left a comment
Member
There was a problem hiding this comment.
Thanks, it's nice to automatically re-run it
github-actions
Bot
added
the
ready
DarkLight1337
left a comment
DarkLight1337
left a comment
Member
There was a problem hiding this comment.
Hmm it doesn't seem to trigger on this PR...
Contributor
Author
Yes, it won't work until this lands on main. Otherwise it would be possible to add a trigger (like on every push) to a pr and bypass whatever trigger conditions the repo maintainers have enforced. |
Member
|
would this retrigger if an unrelated label is added? like if |
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
auto-merge was automatically disabled
April 10, 2026 18:22
Head branch was pushed to by a user without write access
mgoin
approved these changes
Apr 10, 2026
hmellor
reviewed
Apr 10, 2026
wojciech-wais
pushed a commit
to wojciech-wais/vllm
that referenced
this pull request
Apr 13, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
whk-lab
pushed a commit
to whk-lab/vllm
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
Signed-off-by: Fynn Schmitt-Ulms <fschmitt@redhat.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#37544 added a gate to prevent pre-commit from automatically running unless the pr author has at least 4 merged prs or the pr has been labeled. This logic works, but is missing a 'labeled' trigger on the pr. That means if the pr is opened without any label (standard for community authors who don't have labeling permission) and later a 'ready' or 'verified' label is added, the job won't be re-triggered and pre-commit will not run.
Note:
[opened, synchronize, reopened]are the default settings for this github actions trigger, the only new thing islabeled.Reference: https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request
Test Plan
N/A
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.