Skip to content

[CI] Gate pre-commit on ready label or number of contributions#37544

Merged
hmellor merged 9 commits into
vllm-project:mainfrom
hmellor:gate-pre-commit
Mar 19, 2026
Merged

[CI] Gate pre-commit on ready label or number of contributions#37544
hmellor merged 9 commits into
vllm-project:mainfrom
hmellor:gate-pre-commit

Conversation

@hmellor

@hmellor hmellor commented Mar 19, 2026

Copy link
Copy Markdown
Member

pre-commit is experiencing a lot of congestion. This PR should ease the congestion by only running pre-commit:

  • for contributors with 4 or more merged PRs
  • for PRs with the ready label

This change should:

  • be invisible to regular contributors
  • allow maintainers to manually enable the check for new contributors/bots

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@mergify mergify Bot added the ci/build label Mar 19, 2026
hmellor added 2 commits March 19, 2026 10:03
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor added 3 commits March 19, 2026 11:19
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ipped pre-commit

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Mar 19, 2026
@mergify

mergify Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Hi @hmellor, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

hmellor added 2 commits March 19, 2026 15:11
…am on skipped pre-commit"

This reverts commit c2fe2d6.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This reverts commit e03c6b4.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor enabled auto-merge (squash) March 19, 2026 15:12
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2026
@hmellor hmellor merged commit 34f093b into vllm-project:main Mar 19, 2026
13 checks passed
@hmellor hmellor deleted the gate-pre-commit branch March 19, 2026 16:21
chooper26 pushed a commit to vLLM-HUST/vllm-hust that referenced this pull request Mar 21, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mtparet pushed a commit to blackfuel-ai/vllm that referenced this pull request Apr 9, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mvanhorn pushed a commit to mvanhorn/vllm that referenced this pull request Jun 4, 2026
…m-project#37544)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants