[ROCm][CI/Build] Fix the pytest hook to properly print out the summary#38585
Merged
tjtanaa merged 2 commits intovllm-project:mainfrom Apr 3, 2026
Merged
[ROCm][CI/Build] Fix the pytest hook to properly print out the summary#38585tjtanaa merged 2 commits intovllm-project:mainfrom
tjtanaa merged 2 commits intovllm-project:mainfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile.rocm to improve how pytest handles exits in CI by replacing a one-line conftest.py generation with a more detailed heredoc implementation. Feedback suggests ensuring I/O buffers are flushed before the immediate process exit, initializing the exit code to a non-zero value to avoid masking early failures, and correcting the imports.
AndreasKaratzas
added
the
ready
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
gshtras
force-pushed
the
fix_pytest_summary
branch
from
d83d1f9 to
2ef61aa
Compare
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
| # This is a workaround to ensure pytest exits with the correct status code in CI tests. | ||
| RUN echo "import os\n\ndef pytest_sessionfinish(session, exitstatus):\n os._exit(int(exitstatus))" > /vllm-workspace/conftest.py | ||
| RUN cat << 'EOF' > /vllm-workspace/conftest.py | ||
| import os |
Collaborator
There was a problem hiding this comment.
it's missing the sys import too.
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Apr 6, 2026
vllm-project#38585) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
vllm-project#38585) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
vllm-project#38585) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up for #38252
Modifying the ROCm7.2.1 pytest workaround to properly finish including printing the summary, in addition to preserving the exit code