[ROCm][CI-Build] Cherry pick triton BUFFER_OPS fix and update AITER#38580
Merged
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CMake configuration to suppress unused value warnings for HIP and adds a new cherry-pick to the ROCm base Dockerfile. A critical syntax error was identified in the Dockerfile where inline comments were placed before line continuation characters, which would cause the shell to ignore subsequent commands and break the build process.
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
gshtras
changed the title
gshtras
requested review from
LucasWilkinson,
tjtanaa and
tlrmchlsmth
as code owners
tjtanaa
approved these changes
Apr 4, 2026
tjtanaa
left a comment
tjtanaa
left a comment
Member
There was a problem hiding this comment.
LGTM, the release pipeline is also green.
Member
|
@gshtras is there a need for us to trigger the AMD CI tests with these new changes? |
Collaborator
Author
I believe there were test CI runs for the new base. For sure there were runs for both changes separately |
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
1 task
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
mvanhorn
pushed a commit
to mvanhorn/vllm
that referenced
this pull request
Jun 4, 2026
…llm-project#38580) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick triton-lang/triton#9541 into the triton build
Silence the spammy warning that used to be handled by Wno-unused-result
Bump AITER version