[ROCm][CI] Added missing resampy dependency for MM audio tests#37778
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Mar 22, 2026
Merged
[ROCm][CI] Added missing resampy dependency for MM audio tests#37778DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the resampy dependency to requirements/rocm-test.txt, which is necessary for multi-modal audio tests. The change is correct in principle. However, I've identified a critical issue: the existing audio processing code is incompatible with the NumPy version (2.2.6) pinned in the same requirements file. This will lead to runtime errors and prevent the tests from passing. I've added a detailed comment explaining the issue and recommending a fix in a follow-up.
AndreasKaratzas
added
the
ready
DarkLight1337
approved these changes
Mar 22, 2026
RhizoNymph
pushed a commit
to RhizoNymph/vllm
that referenced
this pull request
Mar 26, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
nithinvc
pushed a commit
to nithinvc/vllm
that referenced
this pull request
Mar 27, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…project#37778) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on: #37058
Addresses:
Multi-Modal Models (Standard) 3: llava + qwen2_vlRelated: https://buildkite.com/vllm/amd-ci/builds/6757/steps/canvas?sid=019d0efa-d61c-4621-915a-c06a2f968717&tab=output
cc @kenroche