[Frontend] Remove librosa from audio dependency#37058
[Frontend] Remove librosa from audio dependency#37058Isotr0py merged 27 commits intovllm-project:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the librosa dependency with pyav for audio processing, which is a good move to streamline dependencies. The changes are mostly correct and cover various parts of the codebase, including models, utilities, and tests. However, I've identified two critical issues. First, a new test for pyav resampling is incorrectly implemented and tests the wrong function. Second, the new load_audio_pyav function has a bug where it returns the original sample rate instead of the target sample rate after resampling, which could lead to significant issues in downstream processing. I've provided detailed comments and suggestions to address these critical problems.
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
|
This pull request has merge conflicts that must be resolved before it can be |
1 similar comment
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Purpose
Related issues:
Remove
librosafrom audio dependency, so downstream projects needs audio support likevllm-omnican avoid affected by LGPL.Test Plan
Test Result
All tests should pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.