[Model] Remove unnecessary processor definition for Nemotron Parse#37456
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 18, 2026
Merged
[Model] Remove unnecessary processor definition for Nemotron Parse#37456DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Isotr0py
approved these changes
Mar 18, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the NemotronParseProcessor and its related image processing logic entirely. This includes deleting the vllm/transformers_utils/processors/nemotron_parse.py file, removing its import and usage from vllm/model_executor/models/nemotron_parse.py, and updating vllm/transformers_utils/processors/__init__.py to no longer reference it.
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…llm-project#37456) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: EricccYang <yangyang4991@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The in-tree definition isn't necessary as a processor is already defined on HF Hub: https://huggingface.co/nvidia/NVIDIA-Nemotron-Parse-v1.1/blob/main/hf_nemotron_parse_processor.py
Test Plan
The test that has been renabled by #37407 continues to pass.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.