Skip to content

[Model] Remove unnecessary processor definition for Nemotron Parse#37456

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:rm-nemotron-parse
Mar 18, 2026
Merged

[Model] Remove unnecessary processor definition for Nemotron Parse#37456
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:rm-nemotron-parse

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Mar 18, 2026

Purpose

The in-tree definition isn't necessary as a processor is already defined on HF Hub: https://huggingface.co/nvidia/NVIDIA-Nemotron-Parse-v1.1/blob/main/hf_nemotron_parse_processor.py

Test Plan

The test that has been renabled by #37407 continues to pass.

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 18, 2026 16:23
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2026
@Isotr0py Isotr0py enabled auto-merge (squash) March 18, 2026 16:26
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the NemotronParseProcessor and its related image processing logic entirely. This includes deleting the vllm/transformers_utils/processors/nemotron_parse.py file, removing its import and usage from vllm/model_executor/models/nemotron_parse.py, and updating vllm/transformers_utils/processors/__init__.py to no longer reference it.

@DarkLight1337 DarkLight1337 disabled auto-merge March 18, 2026 18:02
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 18, 2026 18:02
@DarkLight1337 DarkLight1337 merged commit 7476d14 into vllm-project:main Mar 18, 2026
59 checks passed
@DarkLight1337 DarkLight1337 deleted the rm-nemotron-parse branch March 18, 2026 18:25
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
…llm-project#37456)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
…llm-project#37456)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 1, 2026
…llm-project#37456)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: EricccYang <yangyang4991@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants